Quality checks & repository cleanup by pawelrutkaq · Pull Request #101 · eclipse-score/reference_integration

pawelrutkaq · 2026-02-13T08:57:15Z

qnx will fail as it has pull_req_target

github-actions · 2026-02-13T09:04:31Z

The created documentation from the pull request is available at: docu-html

- executes UTs for external modules based on known_good.json file

odra · 2026-02-17T10:31:39Z

~~The AutoSD ci error is not related to the changes of this PR, I think we can merge it so the PR is not block. I will address the CI errors on a different pull request.~~

The CI job has been fixed.

Copilot

Pull request overview

This PR performs a significant repository restructuring and cleanup to consolidate the S-CORE reference integration. The main changes involve:

Changes:

Restructures the repository by moving integration content from integration/ subdirectory to root level
Reorganizes known_good.json to support grouped module structure (target_sw vs tooling)
Adds comprehensive showcase examples (CLI, Kyron, orchestration+persistency, lifecycle, standalone)
Updates all GitHub workflows to work with new structure and adds QNX workflow conditional disable
Removes deprecated files (score_modules.MODULE.bazel, score_toolchains.MODULE.bazel, build_config.json)

Reviewed changes

Copilot reviewed 40 out of 159 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`showcases/*/`	New showcase examples with CLI, Kyron runtime, orchestration+persistency, lifecycle management
`images/*/`	Platform-specific image builds (QNX, Linux, AutoSD, EB) with configs and BUILD files
`runners/*/`	Runner scripts for QEMU and Docker execution
`feature_integration_tests/`	New test infrastructure with Rust scenarios and Python test cases
`bazel_common/*.MODULE.bazel`	Modularized Bazel configuration split by concern (toolchains, modules, etc)
`known_good.json`	Restructured with grouped modules (target_sw, tooling) and metadata
`scripts/known_good/*.py`	Updated scripts supporting grouped structure and pin_version
`.github/workflows/*.yml`	Updated workflows for new structure, disabled integration test temporarily
`MODULE.bazel`, `.bazelrc`	Updated for new structure with includes for modular configuration
`README.md`, `docs/*`	Updated documentation reflecting new structure

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kgraeper · 2026-02-17T10:35:32Z

scripts/known_good/models/known_good.py

-
+
+		Automatically detects flat vs grouped structure:
+		- Flat: {"modules": {"score_baselibs": {...}, "score_logging": {...}}}


I think it is not needed to support both structures. and just go with the grouped one.

scripts/known_good/update_module_from_known_good.py

kgraeper · 2026-02-17T10:41:27Z

.bazelrc

-#
-# See the NOTICE file(s) distributed with this work for additional
-# information regarding copyright ownership.
-#


why was the header removed?

.github/workflows/test_and_docs.yml

.github/workflows/build_and_test_autosd.yml

.github/workflows/build_and_test_linux.yml

kgraeper · 2026-02-17T11:21:55Z

scripts/quality_runners.py

+
+    unit_tests_summary, coverage_summary = {}, {}
+
+    CURRENTLY_DISABLED_MODULES = [


could we put this in the known_good.json?

We put it here since it shall be gone tomorrow once logging repo pushes code that unblocks all modules.

MODULE.bazel

kgraeper · 2026-02-17T11:27:45Z

build_config.json

removing this file will break
scripts/integration_test.py
you can move or integrate it in the script

scripts/integration_test.py is not needed anymore imho. We will need to chop out content after 0.6 that shall run in a reusable workflow that you use from other repos (probably simply quality_checks.py).
The thing is that to really check if module changes does not affect this repo You will have to run most of worflows. And this will yield a long times. So maybe we will just build either quality_check or build_end_tesT_linux, but let's figure this out next week ? At the end, I would not like to maintain yet another command to build modules since it;s frigile (depended what modules does internally etc.)

kgraeper · 2026-02-17T13:20:37Z

LGTM

.github/workflows/docs_cleanup.yml

.github/workflows/known_good_correct.yml

.github/workflows/test_and_docs.yml

FScholPer · 2026-02-17T08:08:02Z

scripts/known_good/models/module.py

+
+        # Split and validate owner/repo format
+        parts = path.split("/", 2)  # Split max 2 times to get owner and repo
+        if len(parts) < 2 or not parts[0] or not parts[1]:


2 should also be handled

what do you exactly mean ?

split array >2 not handled here

done i #103

FScholPer · 2026-02-17T08:08:57Z

scripts/known_good/update_module_from_known_good.py

  python3 scripts/known_good/update_module_from_known_good.py \\
-      --known custom_known_good.json \\
-      --output custom_modules.MODULE.bazel
+      --known custom_known_good.json


can we just move that name in to a variable

Not sure what you're heading to.

hardcoded "custom_known_good.json" path

This is a documentation comment so it uses some name as example

scripts/quality_runners.py

MODULE.bazel

scripts/quality_runners.py

* Align deps to use latest mains - logging used from branch to unblock further work * Prohibit both hash and version * Cleanup based on missed review from #101 * Adapt EB image * Fix QNX build * fix docs deployment * enable UTs for logging - add parsing `extra_test_config` from known_good.json - cleanup code * bump persistency * add baselibs config * Handle errors in split and cleanup workflows * add user selected test execution * fix communication metadata --------- Co-authored-by: Piotr Korkus <piotr.korkus.ext@qorix.ai>

pawelrutkaq added 4 commits February 12, 2026 16:02

Extend structure

07e7512

Adapt structure

5aeeea4

Add generation for long term approach

3e0c62f

Align schema

287f06b

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch 2 times, most recently from e1a8480 to e0643ed Compare February 13, 2026 08:59

Add pipeline checker

61f0449

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from e0643ed to 61f0449 Compare February 13, 2026 09:03

PiotrKorkus and others added 2 commits February 13, 2026 14:48

add external UT python script

565bef2

- executes UTs for external modules based on known_good.json file

Move module to top level

9527746

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from fedbc72 to 50d188c Compare February 13, 2026 15:15

Update all common files

2479ea3

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from 50d188c to 2479ea3 Compare February 13, 2026 15:18

Doc cleanup

fd1265d

pawelrutkaq changed the title ~~Pawelrutkaq know good extensions~~ WIP: Quality checks & repository cleanup Feb 13, 2026

add cpp coverage calculation

d3d4fe4

PiotrKorkus force-pushed the pawelrutkaq_know_good_extensions branch from 298f9c7 to d3d4fe4 Compare February 16, 2026 08:57

fix: codeql and docs

fc348fc

PiotrKorkus force-pushed the pawelrutkaq_know_good_extensions branch from 98a2d5f to fc348fc Compare February 16, 2026 12:09

docs: templates instead of real data

9caf021

PiotrKorkus force-pushed the pawelrutkaq_know_good_extensions branch 6 times, most recently from c9af992 to f057def Compare February 16, 2026 13:21

debug

e6473cc

PiotrKorkus force-pushed the pawelrutkaq_know_good_extensions branch from f057def to e6473cc Compare February 16, 2026 13:43

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from 54b1935 to 6036f1b Compare February 16, 2026 14:23

Try 22.04

62eec60

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from 6036f1b to 62eec60 Compare February 16, 2026 14:29

PiotrKorkus force-pushed the pawelrutkaq_know_good_extensions branch from 8fc0354 to 62eec60 Compare February 16, 2026 15:38

pawelrutkaq and others added 4 commits February 16, 2026 16:54

Align workflows

b724001

Use correct action for cache

6821a10

docs cleanup workflow

d2a2070

test and docs workflow

eab82fe

PiotrKorkus force-pushed the pawelrutkaq_know_good_extensions branch from 24577d3 to eab82fe Compare February 17, 2026 08:23

improve caching

7721f85

pawelrutkaq changed the title ~~WIP: Quality checks & repository cleanup~~ Quality checks & repository cleanup Feb 17, 2026

kgraeper requested a review from Copilot February 17, 2026 10:39

Copilot started reviewing on behalf of kgraeper February 17, 2026 10:40 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

FScholPer requested a review from AlexanderLanin February 17, 2026 11:24

kgraeper suggested changes Feb 17, 2026

View reviewed changes

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from 4f38065 to 3ea9fec Compare February 17, 2026 11:58

Fixes after review

e5f6c22

pawelrutkaq force-pushed the pawelrutkaq_know_good_extensions branch from 3ea9fec to e5f6c22 Compare February 17, 2026 12:00

pawelrutkaq requested a review from kgraeper February 17, 2026 12:22

kgraeper approved these changes Feb 17, 2026

View reviewed changes

PiotrKorkus approved these changes Feb 17, 2026

View reviewed changes

pawelrutkaq merged commit ed60836 into eclipse-score:main Feb 17, 2026
10 of 11 checks passed

FScholPer reviewed Feb 17, 2026

View reviewed changes

pawelrutkaq added a commit to qorix-group/reference_integration that referenced this pull request Feb 17, 2026

Cleanup based on missed review from eclipse-score#101

9bde0aa

pawelrutkaq added a commit to qorix-group/reference_integration that referenced this pull request Feb 17, 2026

Cleanup based on missed review from eclipse-score#101

cabd2fd



		Automatically detects flat vs grouped structure:
		- Flat: {"modules": {"score_baselibs": {...}, "score_logging": {...}}}


		unit_tests_summary, coverage_summary = {}, {}

		CURRENTLY_DISABLED_MODULES = [

Conversation

pawelrutkaq commented Feb 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 13, 2026

Uh oh!

odra commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawelrutkaq Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kgraeper commented Feb 17, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FScholPer Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pawelrutkaq commented Feb 13, 2026 •

edited

Loading

odra commented Feb 17, 2026 •

edited

Loading

pawelrutkaq Feb 17, 2026 •

edited

Loading

FScholPer Feb 17, 2026 •

edited

Loading